Skip to content

archive/tar: test tarinsecurepath behavior for link targets#79885

Open
Abhinav-143x wants to merge 1 commit into
golang:masterfrom
Abhinav-143x:tar-linkname-tarinsecurepath-test
Open

archive/tar: test tarinsecurepath behavior for link targets#79885
Abhinav-143x wants to merge 1 commit into
golang:masterfrom
Abhinav-143x:tar-linkname-tarinsecurepath-test

Conversation

@Abhinav-143x
Copy link
Copy Markdown

@Abhinav-143x Abhinav-143x commented Jun 6, 2026

Clarify the Reader.Next documentation for tarinsecurepath=0 and add
regression coverage for link targets.

The tarinsecurepath check reports ErrInsecurePath for non-local Header.Name
values, but it does not validate Header.Linkname. That distinction matters for
archive consumers that use archive/tar as part of extraction or policy
enforcement: link targets need to be handled by the extractor's own filesystem
policy.

This change preserves the current behavior. It rewords the Reader.Next comment
so the ErrInsecurePath behavior reads directly, keeps the existing statement
that only file names are validated, and adds tests for TypeLink and TypeSymlink
entries with non-local link targets while GODEBUG=tarinsecurepath=0.

The new test confirms that the tarinsecurepath check applies to the entry name
and not to the link target. This should help prevent future regressions or
ambiguous assumptions around link handling in archive/tar readers.

No issue: this is a documentation and test clarification for existing behavior.

Tests:

  • go_bootstrap.exe test archive/tar
  • go_bootstrap.exe test archive/...

Review requested. Please let me know if this should be adjusted to emphasize
the test coverage only, or if there is a preferred wording for the Reader.Next
documentation.

@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: e361d77) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/787880.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/787880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/787880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Abhinav Gaur:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/787880.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants